[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts
From: |
Doro Rose |
Subject: |
Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts |
Date: |
Thu, 16 Nov 2017 23:22:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (darwin) |
Nicolas Goaziou <address@hidden> writes:
> Doesn't this kind of configuration ultimately belongs to the user? Org
> is not supposed to mess with `haskell-prompt-regexp' in the current
> buffer, IMO."Doesn't this kind of configuration ultimately belongs to the
> user? Org
I figured, since I'm only adding another regexp to an existing regexp, no harm
is done, as all else stays equal, i.e. all previously
valid matches are still valid.
>> + (comint-preoutput-filter-functions
>> + (cons 'ansi-color-filter-apply
>> comint-preoutput-filter-functions))
>
> Ditto.
Adding `ansi-color-filter-apply' only ensures that color escape sequences are
handled properly.
In summary, yes I'm accessing user settings but in a rather noninvasive way.
Unfortunately I can't think of a more elegant way
to do this.