[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags |
Date: |
Sun, 11 Feb 2018 17:25:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Sebastian Reuße <address@hidden> writes:
> I also considered adding a regression test for non-ASCII chars to
> «test-org/sort-entries», but for stable results, one would have to
> enforce some canonical locale. Unfortunately, it’s not possible to
> change the locale at Emacs run-time; Emacs only seems to call
> «setlocale()» once during initialization, so «wcscoll()» always collates
> according to the initial value of «LC_COLLATE». A regression test would
> thus require changes to the Makefile, and tests might yield different
> results when run from inside an existing Emacs process, so I left the
> «sort-entries» test as is.
It should be possible to redefine `string-collate-lessp', using
`cl-letf' so that is uses different locales as the optional argument.
WDYT?
The patch looks good. Thank you. It would be good to add an entry in
ORG-NEWS about it, however.
Then we can improve `org-table-sort-lines' accordingly. It can be done
in another patch, tho.
- [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/06
- [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/06
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Nicolas Goaziou, 2018/02/10
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/11
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags,
Nicolas Goaziou <=
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/12
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Nicolas Goaziou, 2018/02/12
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/12
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Nicolas Goaziou, 2018/02/12
- [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/12
- Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags, Nicolas Goaziou, 2018/02/12
- [O] [PATCH] Fix alphabetic sorting for headlines, tags, Sebastian Reuße, 2018/02/11