emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Two ob-lua versions


From: address@hidden
Subject: Re: [O] Two ob-lua versions
Date: Wed, 14 Feb 2018 18:29:30 +0800

I created a PR now https://code.orgmode.org/bzg/org-mode/pulls/4 . Really sorry for this. @Nicolas , can you merge it now?

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Wed, Feb 14, 2018 at 6:18 PM, address@hidden <address@hidden> wrote:
Hi, sorry for this. I have not noticed that. I will create an PR to remove my `ob-lua.el` as soon as fast.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <address@hidden> wrote:
hi,

On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <address@hidden> wrote:
> Hello,
>
> Thibault Marin <address@hidden> writes:
>
>> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
>> Since there is already an ob-lua.el in lisp/, I was wondering if the new
>> version was adding functionality not supported by the one in lisp/ (it
>> does not seem to be the case on casual inspection) and if so, whether
>> they could/should be merged.
>
> I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
> can have some insight about it.

Anyway this breaks installation with package.el in org-plus-contrib case.
because of conflicting "ob-lua.el" filename.

> stardiviner, would you mind explaining why you need to create an
> "ob-lua.el" library in "contrib/" ?

It has to be fixed, so please revert that merge, until stardiviner will notice
this thread and retry PR...

regards,
--
KURASHIKI Satoru




reply via email to

[Prev in Thread] Current Thread [Next in Thread]