Re: ls-lisp patch

[Markus Rost]

       If you load ls-lisp.el for some reason, for instance with

       M-x customize-group ls-lisp

       then the function insert-directory gets redefined.  That can be
       unfortunate.

   Thanks for noticing this.  You are right, this is a bug.

   However, I see no need to rename the variable or make it a minor mode.
   All that's needed is to change the default value of the variable,
   to make that conditional on the system.

So, what about the following patch:

        * ls-lisp.el (ls-lisp-use-insert-directory-program): Make default
        value system dependent.
        (ls-lisp-support-shell-wildcards): Add autoload cookie.

===Buffer *diff*============================================
cd /home/rost/cvs/emacs/lisp/
diff -c /home/rost/cvs/emacs/lisp/ls-lisp.el /tmp/buffer-content-24321zuO
*** /home/rost/cvs/emacs/lisp/ls-lisp.el        Sat Dec 21 15:20:47 2002
--- /tmp/buffer-content-24321zuO        Sat Jan 18 18:27:14 2003
***************
*** 129,135 ****
              (const :tag "Show Group" gid))
    :group 'ls-lisp)
  
! (defcustom ls-lisp-use-insert-directory-program nil
    "*Non-nil causes ls-lisp to revert back to using `insert-directory-program'.
  This is useful on platforms where ls-lisp is dumped into Emacs, such as
  Microsoft Windows, but you would still like to use a program to list
--- 129,136 ----
              (const :tag "Show Group" gid))
    :group 'ls-lisp)
  
! (defcustom ls-lisp-use-insert-directory-program
!   (not (memq system-type '(macos ms-dos windows-nt)))
    "*Non-nil causes ls-lisp to revert back to using `insert-directory-program'.
  This is useful on platforms where ls-lisp is dumped into Emacs, such as
  Microsoft Windows, but you would still like to use a program to list
***************
*** 137,142 ****
--- 138,145 ----
    :type 'boolean
    :group 'ls-lisp)
  
+ ;;; Autoloaded because it is let-bound in `recover-session', `mail-recover-1'.
+ ;;;###autoload
  (defcustom ls-lisp-support-shell-wildcards t
    "*Non-nil means ls-lisp treats file patterns as shell wildcards.
  Otherwise they are treated as Emacs regexps (for backward compatibility)."

Diff finished at Sat Jan 18 18:27:15

============================================================