emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problems with ANSI colors in shell mode in Emacs 21.2.95.


From: Kim F. Storm
Subject: Re: Problems with ANSI colors in shell mode in Emacs 21.2.95.
Date: 11 Feb 2003 14:25:03 +0100
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

Lute Kamstra <address@hidden> writes:

> Richard Stallman <address@hidden> writes:
> 
> >     I tested a few old pretests and found out that the problem first
> >     occurred in Emacs 21.2.91.  In Emacs 21.2.90, the shell prompt looks
> >     fine.
> > 
> > Can you identify the Emacs change that did it?
> 
> Yes.  The change in shell.el is causing the change in behavior.  With
> Emacs 21.2.91, a new user option is introduced in Emacs.  Here's the
> changelog entry:
> 
> ,----
> | 2002-07-30  Andreas Schwab  <address@hidden>
> | 
> |     * shell.el (explicit-bash-args): New user option.
> `----
> 
> The user option looks like this:
> 
> ,----[ shell.el; lines 278-284 ]
> | (defcustom explicit-bash-args
> |     ;; Tell bash not to use readline.
> |     '("--noediting" "-i")
> |   "*Args passed to inferior shell by M-x shell, if the shell is bash.
> | Value is a list of strings, which may be nil."
> |   :type '(repeat (string :tag "Argument"))
> |   :group 'shell)
> `----

This is unrelated to the actual problem, but it reminds me that I
installed the following fix on CVS head to make this work with
bash 1.x which doesn't grook --noediting:

(defcustom explicit-bash-args
  ;; Tell bash not to use readline, except for bash 1.x which doesn't grook 
--noediting.
  ;; Bash 1.x has -nolineediting, but process-send-eof cannot terminate bash if 
we use it.
  (let* ((prog (or (and (boundp 'explicit-shell-file-name) 
explicit-shell-file-name)
                   (getenv "ESHELL") shell-file-name))
         (name (file-name-nondirectory prog)))
    (if (and (not purify-flag)
             (equal name "bash")
             (file-executable-p prog)
             (string-match "bad option"
                           (shell-command-to-string (concat prog " 
--noediting"))))
        '("-i")
      '("--noediting" "-i")))
  "*Args passed to inferior shell by M-x shell, if the shell is bash.
Value is a list of strings, which may be nil."
  :type '(repeat (string :tag "Argument"))
  :group 'shell)

We should probably merge the fix to the RC branch.

-- 
Kim F. Storm  http://www.cua.dk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]