emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[smtpmail.el] Inappropriate use of `kill-line'


From: Jesper Harder
Subject: [smtpmail.el] Inappropriate use of `kill-line'
Date: Wed, 07 May 2003 03:53:13 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (gnu/linux)

In GNU Emacs 21.3.50.75 (i686-pc-linux-gnu)
 of 2003-05-06 on defun.localdomain

Hi!

`kill-line' isn't the right thing to use in
`smtpmail-send-queued-mail' because it interferes with the user's
kill-ring.

        * smtpmail.el (smtpmail-send-queued-mail): Don't use kill-line.

Attachment: smtpmail.el.diff
Description: Text Data

By the way, maybe there should be a function called `delete-line'.
Grepping the source shows that it's needed numerous times -- there's
already

(defmacro gnus-delete-line (&optional n)
  `(delete-region (gnus-point-at-bol)
                  (progn (forward-line ,(or n 1)) (point))))

and `woman-delete-line', `ses-delete-line', `gdb-delete-line' and so
on.

-- 
Cheers,
Jesper Harder

reply via email to

[Prev in Thread] Current Thread [Next in Thread]