after-find-file's obsolete invocation of sit-for confuses advice

[Alex Coventry]

Symptoms:

Running CVS emacs checked out this morning, with follow.el loaded, the
command C-x C-f ~/foobar/baz errored out in after-find-file, on an
out-of-date three-argument call to sit-for.  Here, foobar is a
non-existant directory, so I should have gotten a message suggesting
that I run make-directory.  The error is quite disruptive, because it
happens before the mode of the new buffer can be set

This error presumably arises because sit-for is lying about its argument
signature, although I haven't checked that it is, and defadvice doesn't
know to look for this.  If that's the case, the real answer might be to
teach defadvice better.  However, bringing after-find-file into the
present day works too, in this case.  I'm runnig the patch below, now.
Note that because a compiled version of files is in the emacs binary (or
something like that, I'm fuzzy on the details...) you have to explicitly
evaluate the revised after-find-file to get this to work, it's not
enough just to change files.el{c,} in the share directory and start a
new emacs.

Hope this helps.
Alex.

*** files.el.~1.660.~   Sat May 31 08:36:53 2003
--- files.el    Sun Jun  1 21:31:13 2003
***************
*** 1529,1535 ****
                "Use C-u M-x make-directory RET RET to create directory and its 
parents")))))
        (when msg
        (message "%s" msg)
!       (or not-serious (sit-for 1 nil t))))
      (when (and auto-save-default (not noauto))
        (auto-save-mode t)))
    ;; Make people do a little extra work (C-x C-q)
--- 1529,1535 ----
                "Use C-u M-x make-directory RET RET to create directory and its 
parents")))))
        (when msg
        (message "%s" msg)
!       (or not-serious (sit-for 1 t))))
      (when (and auto-save-default (not noauto))
        (auto-save-mode t)))
    ;; Make people do a little extra work (C-x C-q)



In GNU Emacs 21.3.50.3 (i686-pc-linux-gnu, X toolkit)
 of 2003-06-01 on coventry
configured using `configure '--prefix=/scratch2/alex/''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Recent input:
2 / a l TAB / e m TAB l i TAB s TAB / f i TAB l e TAB 
s . TAB RET C-x v v C-x k RET C-x o C-x v = C-x o C-s 
o r SPC n o t SPC s e C-h C-h C-g C-s o r SPC n o t 
SPC C-b C-s o r SPC n o t - s e a C-s C-g C-g C-s o 
r SPC n o t C-s SPC C-n C-s C-s C-g o r SPC n o t - 
C-s M-v M-v M-x M-p RET

Recent messages:
Loading log-edit...
Loading easy-mmode...done
Loading log-edit...done
Mark set
Press C-c C-c when you are done editing.
Enter a change comment.  Type C-c C-c when done
Loading compile...done
Mark saved where search started [2 times]
Quit [3 times]
Mark saved where search started [2 times]