Re: Cursor not redrawn

[Kim F. Storm]

"Jan D." <address@hidden> writes:

> Hello.
> 
> The bug was introduced by this change:
> 
> 2003-05-28  Kim F. Storm  <address@hidden>
> 
>         * xdisp.c (expose_window): Fix error in calculation of
>         window relative coordinates of area to redisplay.
> 
> 
> Here is a diff:
> --- ../../10/src/xdisp.c        2003-05-27 00:06:33.000000000 +0200
> +++ ./xdisp.c   2003-05-28 01:30:10.000000000 +0200
> @@ -20283,8 +20283,8 @@
>               r.x, r.y, r.width, r.height));
>  
>        /* Convert to window coordinates.  */
> -      r.x = FRAME_TO_WINDOW_PIXEL_X (w, r.x);
> -      r.y = FRAME_TO_WINDOW_PIXEL_Y (w, r.y);
> +      r.x -= WINDOW_LEFT_EDGE_X (w);
> +      r.y -= WINDOW_TOP_EDGE_Y (w);
>  
>        /* Turn off the cursor.  */
>        if (!w->pseudo_window_p
> 
> Apparently the cursors coordinates end up outside the frame in this case.
> Checking these defines one sees that FRAME_TO_WINDOW_PIXEL_X is not the
> same as -= WINDOW_LEFT_EDGE_X but rather -= WINDOW_BOX_LEFT_EDGE_X

That is intentional!

> 
> Doing that change cures this problem, but since I don't know what this
> change was supposed to fix originally, I suggest Kim makes the appropriate
> change.

The patch fixed a problem with not redrawing 2-3 columns when exposing
a partially covered emacs window.

I'll investigate why the cursor isn't redrawn correctly.

-- 
Kim F. Storm  http://www.cua.dk