Use of `gtk_window_set_icon_from_file' in src/xfns.c

[Lute Kamstra]

The problem described in the two mails below still persists.  It was
introduced by the following change (committed by Juanma).

,----
| 2003-07-13  Terje Rosten  <address@hidden>
| 
|       * xterm.c (x_bitmap_icon,x_wm_set_icon_pixmap): Modify to add mask,
|       and use the Gtk+ function gtk_window_icon_from_file if available.
| 
|       * xfns.c (x_bitmap_mask, x_create_bitmap_mask): New functions to
|       handle mask of bitmaps.
|       (x_allocate_bitmap_record, x_destroy_bitmap): Modify to handle the
|       mask property.
|       (xg_set_icon): New function, wrapper for gtk_window_icon_from_file.
| 
|       * xterm.h (xg_set_icon): New function.
`----

As I understand things, there are three solutions:

   1. Revert the change.

   2. Let the configure script distinguish between 2.01 <= GTK < 2.2
      and GTK >= 2.2 and revert the change for the first case.

   3. Let the configure script require GTK >= 2.2 in order to compile
      Emacs with GTK.

The second option is probably best, but my knowledge of autoconf is
too limited to implement this.  Volunteers?

Lute.

> --- Begin Message ---
>
>
>
> Subject: 
>
> Topics
>
>
>
>
> Topics:
>    Build failure: undefined reference to `gtk_window_set_icon_from_file'
>    xfns.c uses GTK function from 2.2, configure requires 2.0.1
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Build failure: undefined reference to `gtk_window_set_icon_from_file'
>
>
>
>
> Date: 
>
> Tue, 15 Jul 2003 23:12:52 +0200
>
>
>
>
> Emacs fails to build with the following error:
>
> gcc -nostdlib `./prefix-args -Xlinker  -R/usr/X11R6/lib -z nocombreloc` 
> -L/usr/X11R6/lib -o temacs pre-crt0.o /usr/lib/crt1.o /usr/lib/crti.o dispnew.o 
> frame.o scroll.o xdisp.o xmenu.o window.o charset.o coding.o category.o ccl.o 
> cm.o term.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o 
> gtkutil.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o 
> insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o casetab.o 
> casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o 
> callint.o eval.o floatfns.o fns.o print.o lread.o abbrev.o syntax.o unexelf.o 
> bytecode.o process.o callproc.o region-cache.o sound.o atimer.o doprnt.o 
> strftime.o intervals.o textprop.o composite.o md5.o   terminfo.o lastfile.o   
> vm-limit.o   mktime.o    -L/usr/X11R6/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 
> -lgdk_pixbuf-2.0 -lm -lpangox-1.0 -lpangoxft-1.0 -lpango-1.0 -lgobject-2.0 
> -lgmodule-2.0 -ldl -lglib-2.0 -lSM -lICE -ltiff -ljpeg -lungif -lXpm -lX11  
> -lncurses   -lm -lgcc -lc -lgcc /usr/lib/crtn.o 
> xfns.o: In function `xg_set_icon':
> /home/harder/emacs/src/xfns.c:1111: undefined reference to 
> `gtk_window_set_icon_from_file'
> collect2: ld returned 1 exit status
> make[1]: *** [temacs] Error 1
> make[1]: Leaving directory `/home/harder/emacs/src'
> make: *** [src] Error 2
>
> This is on Redhat 7.3.
>
>
> In GNU Emacs 21.3.50.141 (i686-pc-linux-gnu)
>  of 2003-07-11 on defun.localdomain
> configured using `configure '--with-gtk''
>
>
>
> _______________________________________________
> Emacs-pretest-bug mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/emacs-pretest-bug
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> xfns.c uses GTK function from 2.2, configure requires 2.0.1
>
>
>
>
> Date: 
>
> Wed, 16 Jul 2003 08:56:25 +0200
>
>
>
>
> [originally sent July 14th; resending now, as my past two bug
> reports have bounced]
>
> Emacs does not at the moment build for me; there is an undefined
> reference:
>
> > xfns.o: In function `xg_set_icon':
> > /home/tim/gnu/emacs/src/xfns.c:1111: undefined reference to
> `gtk_window_set_icon_from_file'
>
> This function was introduced in GTK+ 2.2, but the configure script still
> checks for 2.0.1 or higher.
> The obvious patch is below.
>
> --- configure.in.~1.343.~       2003-07-14 08:39:49.000000000 +0200
> +++ configure.in        2003-07-14 09:30:39.000000000 +0200
> @@ -1881,7 +1881,7 @@ if test "${with_gtk}" = "yes" || test "$
>      AC_MSG_ERROR([Conflicting options, --with-gtk is incompatible with
> --with-x-toolkit=${with_x_toolkit}]);
>    fi
>    GLIB_REQUIRED=2.0.1
> -  GTK_REQUIRED=2.0.1
> +  GTK_REQUIRED=2.2
>    GTK_MODULES="gtk+-2.0 >= $GTK_REQUIRED glib-2.0 >= $GLIB_REQUIRED"
>  
>    dnl Check if --with-pkg-config-prog has been given.
>
>
> -- 
> Tim Van Holder <mailto:address@hidden>
> Anubex         <http://www.anubex.com>
>
> -- This e-mail was scanned by RAV Antivirus --
>
>
>
> _______________________________________________
> Emacs-pretest-bug mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/emacs-pretest-bug
>
>
> --- End Message ---