emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: edebug breaks pre,post-command-hook


From: Stefan Monnier
Subject: Re: edebug breaks pre,post-command-hook
Date: 05 Sep 2003 12:02:14 -0400
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

> ***************
> *** 2241,2248 ****
  
>           ;; Save the outside value of executing macro.  (here??)
>           (edebug-outside-executing-macro executing-kbd-macro)
> !         (edebug-outside-pre-command-hook pre-command-hook)
> !         (edebug-outside-post-command-hook post-command-hook))
>       (unwind-protect
>           (let (;; Don't keep reading from an executing kbd macro
>                 ;; within edebug unless edebug-continue-kbd-macro is
> --- 2241,2250 ----
  
>           ;; Save the outside value of executing macro.  (here??)
>           (edebug-outside-executing-macro executing-kbd-macro)
> !         (edebug-outside-pre-command-hook
> !          (cons (current-buffer) pre-command-hook))
> !         (edebug-outside-post-command-hook
> !          (cons (current-buffer) post-command-hook)))
>       (unwind-protect
>           (let (;; Don't keep reading from an executing kbd macro
>                 ;; within edebug unless edebug-continue-kbd-macro is

I think edebug should not try to reproduce the behavior of `let'
which was already hard to implement once.

How about just doing

(let ((pre-command-hook pre-command-hook)
      (post-command-hook post-command-hook))
  ...)

instead of fiddling with edebug-outside-pre-command-hook ?
Or if we need to remember the value outside, then

(let ((pre-command-hook pre-command-hook)
      (post-command-hook post-command-hook)
      (edebug-outside-pre-command-hook pre-command-hook)
      (edebug-outside-post-command-hook post-command-hook))
  ...)



-- Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]