Re: Recent change of lm-with-file in emacs-lisp/lisp-mnt.el.

[Lute Kamstra]

Richard Stallman <address@hidden> writes:

>     Maybe the change can be fixed so that lm-with-file handles FILE == nil
>     as before?
>
> Does this work right?
>
> (defmacro lm-with-file (file &rest body)
>   "Execute BODY in a buffer containing the contents of FILE.
> If FILE is nil, just return nil."
>   (let ((filesym (make-symbol "file")))
>     `(let ((,filesym ,file))
>        (if ,filesym
>          (with-temp-buffer
>            (insert-file-contents ,filesym)
>            ,@body)
>        ,@body))))

Almost.  BODY used to be wrapped in a save-excursion (docstring
updated too):

(defmacro lm-with-file (file &rest body)
  "Execute BODY in a temporary buffer containing the contents of FILE.
If FILE is nil, execute BODY in the current buffer."
  (let ((filesym (make-symbol "file")))
    `(let ((,filesym ,file))
       (if ,filesym
           (with-temp-buffer
             (insert-file-contents ,filesym)
             ,@body)
         (save-excursion
           ,@body)))))

Isn't it bad to refer to BODY twice?

  Lute.