Problem with eshell-ls-use-in-dired.

[Matt Hodges]

In GNU Emacs 21.3.50.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2003-11-19 on dugong
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

The following with emacs --no-init-file --no-site-file:

    (1) (progn (eshell) (dired "/tmp"))

    (2) M-x customize-variable RET eshell-ls-use-in-dired RET

    (3) Toggle and set for current session

    (4) update dired buffer [insert-directory is now an alias for
        eshell-ls-insert-directory]

gives the following backtrace:

    Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
      eshell-interactive-output-p()
      eshell-gather-process-output("/bin/ls" ("--dired" "-al" "/tmp/"))
      eshell-external-command("/bin/ls" ("--dired" "-al" "/tmp/"))
      eshell-do-opt("ls" ((97 "all" nil show-all "show all files in directory") 
(99 nil by-ctime sort-method "sort by modification time") (100 "directory" nil 
dir-literal "list directory entries instead of contents") (107 "kilobytes" 1024 
block-size "using 1024 as the block size") (104 "human-readable" 1024 
human-readable "print sizes in human readable format") (72 "si" 1000 
human-readable "likewise, but use powers of 1000 not 1024") (73 "ignore" t 
ignore-pattern "do not list implied entries matching pattern") (108 nil 
long-listing listing-style "use a long listing format") (110 "numeric-uid-gid" 
nil numeric-uid-gid "list numeric UIDs and GIDs instead of names") (114 
"reverse" nil reverse-list "reverse order while sorting") (115 "size" nil 
show-size "print size of each file, in blocks") (116 nil by-mtime sort-method 
"sort by modification time") (117 nil by-atime sort-method "sort by last access 
time") (120 nil by-lines listing-style "list entries by lines instead of by 
columns") (67 nil by-columns listing-style "list entries by columns") (76 
"deference" nil dereference-links "list entries pointed to by symbolic links") 
(82 "recursive" nil show-recursive "list subdirectories recursively") (83 nil 
by-size sort-method "sort by file size") (85 nil unsorted sort-method "do not 
sort; list entries in directory order") (88 nil by-extension sort-method "sort 
alphabetically by entry extension") (49 nil single-column listing-style "list 
one file per line") (nil "help" nil nil "show this usage display") :external 
"ls" :usage "[OPTION]... [FILE]...\nList information about the FILEs (the 
current directory by default).\nSort entries alphabetically across.") ((unless 
block-size (setq block-size eshell-ls-default-blocksize)) (unless listing-style 
(setq listing-style ...)) (unless args (setq args ...)) (let (... ange-cache) 
(when ignore-pattern ... ... ...) (eshell-ls-entries ... t ...)) (funcall 
flush-func)))
      eshell-do-ls(("--dired" "-al" "/tmp/"))
      insert-directory("/tmp/" "--dired -al" nil t)
      dired-insert-directory("/tmp/" "-al" nil nil t)
      dired-readin-insert()
      dired-readin()
      dired-revert(t nil)
      revert-buffer(t)
      call-interactively(revert-buffer)

This seems to be entirely general as far as I can tell, i.e., it fails
in any directory (and isn't limited to reverting dired buffers).

Works as expected in 21.3 (i.e., eshell faces appear in dired
buffers).

Thanks,

Matt