dired-insert-directory bug?

[Katsumi Yamaoka]

Hi,

It seems that there's a wrong logic in the dired-insert-directory
function.  When accessing a remote directory, it adds the --dired
option to dired-listing-switches (i.e., the ls command options).
However, it won't be accepted by all remotehosts.  How about the
following patch?

*** dired.el~   Tue Feb  3 22:44:34 2004
--- dired.el    Fri Feb 13 08:52:17 2004
***************
*** 694,700 ****
    (let ((opoint (point))
        (process-environment (copy-sequence process-environment))
        end)
!     (if (or dired-use-ls-dired (file-remote-p dir))
        (setq switches (concat "--dired " switches)))
      ;; We used to specify the C locale here, to force English month names;
      ;; but this should not be necessary any more,
--- 694,700 ----
    (let ((opoint (point))
        (process-environment (copy-sequence process-environment))
        end)
!     (if (and dired-use-ls-dired (not (file-remote-p dir)))
        (setq switches (concat "--dired " switches)))
      ;; We used to specify the C locale here, to force English month names;
      ;; but this should not be necessary any more,

I noticed this problem while fiddling ange-ftp.el imported from
Emacs 19.34b. :)

Regards,
-- 
Katsumi Yamaoka <address@hidden>