emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: comment-filling fixes


From: Stefan Monnier
Subject: Re: comment-filling fixes
Date: 18 Mar 2004 11:38:02 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>> I actually fixed this a couple days ago.  My fix is similar to
>> yours.
> Actually, my fix was wrong/incomplete.

I can't guess what you're referring to, but I know that your code failed in
the case of

    foo ;;; asdg
    ;; bar

The installed code gets this right.

>> The difference with yours is that it only uses syntax-ppss if the major
>> mode sets a specific variable.  The reason for it is that in major modes
>> like tex-mode or perl-mode where the syntax-tables are not quite up to the
>> task, using syntax-ppss means that if the syntax functions get confused the
>> comment-related operations suddenly don't work at all any more.

> That seems backwards to me.  Why penalize most modes?

Backward compatibility?
People haven't been whining very loud about the bug this new feature fixes,
so I think it's best to stay conservative than to risk introducing new bugs.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]