emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bad regexp in auto-save-file-name-transforms


From: Chris Moore
Subject: bad regexp in auto-save-file-name-transforms
Date: Fri, 23 Apr 2004 00:31:55 +0200

On 09 Apr 2004 at 14:05:26 +0200, I wrote:

 > If tramp-auto-save-directory is nil, and I'm using tramp to edit a
 > file in the root directory of a remote machine, the auto-save
 > filename that is generated is bad.

and I offered a patch which seemed to be ignored:

 > -------cut-here-------8<--------cut-here--------8<-------cut-here-------
 > --- Backup/files.el.~1~      2004-04-02 17:12:48.000000000 +0200
 > +++ files.el 2004-04-09 13:49:58.634318672 +0200
 > @@ -293,7 +293,7 @@
 >    :group 'auto-save)
 >  
 >  (defcustom auto-save-file-name-transforms
 > -  `(("\\`/[^/]*:\\(.+/\\)*\\(.*\\)"
 > +  `(("\\`/[^/]*:/?\\(.+/\\)*\\(.*\\)"
 >       ;; Don't put "\\2" inside expand-file-name, since it will be
 >       ;; transformed to "/2" on DOS/Windows.
 >       ,(concat temporary-file-directory "\\2") t))
 > -------cut-here-------8<--------cut-here--------8<-------cut-here-------

What I didn't notice was that the same variable is also defined in
lisp/startup.el, where it also needs to be changed in the same way,
and so the patch becomes the following:

-------cut-here-------8<--------cut-here--------8<-------cut-here-------
Index: files.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/files.el,v
retrieving revision 1.689
diff -u -c -r1.689 files.el
cvs server: conflicting specifications of output style
*** files.el    17 Apr 2004 19:58:19 -0000      1.689
--- files.el    22 Apr 2004 22:26:17 -0000
***************
*** 293,299 ****
    :group 'auto-save)
  
  (defcustom auto-save-file-name-transforms
!   `(("\\`/[^/]*:\\(.+/\\)*\\(.*\\)"
       ;; Don't put "\\2" inside expand-file-name, since it will be
       ;; transformed to "/2" on DOS/Windows.
       ,(concat temporary-file-directory "\\2") t))
--- 293,299 ----
    :group 'auto-save)
  
  (defcustom auto-save-file-name-transforms
!   `(("\\`/[^/]*:/?\\(.+/\\)*\\(.*\\)"
       ;; Don't put "\\2" inside expand-file-name, since it will be
       ;; transformed to "/2" on DOS/Windows.
       ,(concat temporary-file-directory "\\2") t))
Index: startup.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/startup.el,v
retrieving revision 1.327
diff -u -c -r1.327 startup.el
cvs server: conflicting specifications of output style
*** startup.el  13 Apr 2004 22:20:04 -0000      1.327
--- startup.el  22 Apr 2004 22:26:34 -0000
***************
*** 575,581 ****
        (if (eq system-type 'ms-dos)
            (getenv "TMPDIR")))
    (setq auto-save-file-name-transforms
!       (list (list "\\`/[^/]*:\\(.+/\\)*\\(.*\\)"
                    ;; Don't put "\\2" inside expand-file-name, since
                    ;; it will be transformed to "/2" on DOS/Windows.
                    (concat temporary-file-directory "\\2") t)))
--- 575,581 ----
        (if (eq system-type 'ms-dos)
            (getenv "TMPDIR")))
    (setq auto-save-file-name-transforms
!       (list (list "\\`/[^/]*:/?\\(.+/\\)*\\(.*\\)"
                    ;; Don't put "\\2" inside expand-file-name, since
                    ;; it will be transformed to "/2" on DOS/Windows.
                    (concat temporary-file-directory "\\2") t)))
-------cut-here-------8<--------cut-here--------8<-------cut-here-------

Chris.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]