emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: suggestion for compile.el


From: Daniel Pfeiffer
Subject: Re: suggestion for compile.el
Date: Thu, 13 May 2004 23:56:09 +0200

Saluton,

Dan Nicolaescu <address@hidden> skribis:

>   > I had tried your patch that way.  This function in wterm, aterm or KDE's
>   > konsole, always tells me 8.
> 
> Well, then the patch should not change anything for you. The
> face colors for compile-* should be the same before and after the
> patch. 

That's why I didn't like the patch.  All of wterm, aterm and rxvt (which seem
to share some common ancestry) have colors 0 through 15.  The reported 8
probably refers to Ansi, where the remaining colors are supposed to be bright
variants of the Ansi colors.  But in fact they can be freely set to whatever
you please.

> What the patch is trying to do is to make the terminals that support
> at least 16 colors use the same colors as the X faces do. Anything
> else should remain the same. All other cases are supposed to stay the
> same. I was deliberately not trying to change any colors, just to
> improve the support for terminals that support a high number of
> colors.

Maybe min-color has an off-by-one bug?  If you can send a patch that starts at
15 and also handles errors in an equally bright and bold style, I'll have a
look at it.

> 16 is chosen because dos/windows terminals support 16 colors. 

Not my favorite reason to install a patch — I prefer to live in a free world.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

-- 
lerne / learn / apprends / läramå / ucz się    Esperanto:
                              http://lernu.net/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]