emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: with-selected-window (was: Problems with compile-mode)


From: Stefan Monnier
Subject: Re: with-selected-window (was: Problems with compile-mode)
Date: 02 Jun 2004 01:53:52 -0400
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>     So would it be OK to only save&restore the other frame's
>     frame-selected-window rather than the one of every single frame?

> It would prevent the specific bug that I mentioned, but why is this is
> an improvement?  The current code seems cleaner to me.  Why change it?

Well, there is the fact that it in not guaranteed that it will not
mess with the buffer ordering (because it calls set-frame-select-window
which might call select-window without the `norecord' argument), contrary
to what the docstring says.

Also it seems wrong that it will save&restore everything under the sun when
we know full well that it should only need to pay attention to the current
window and the one temporarily selected.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]