Re: ediff possible bug

[Michael Kifer]

Peter,
The patch that you provided seems to be against an older version of ediff.
I cannot really tell what your patch is supposed to do and whether the
current version already does the job.

>>>>> "MfPL" == Message from Peter Lee <<address@hidden> > writes:

    >>>>> Michael Kifer writes:

    MK> There are many ways in which the heuristic for selecting files
    MK> in ediff could be improved. The question is whether the
    MK> implementation effort and the complications that would arise
    MK> are justified when the existing heuristic already supports
    MK> idioms that require the same or fewer number of keystrokes as
    MK> the suggestion. (e.g., ediff-buffers)

    MfPL> I use ediff a lot and, for me, using ediff-buffers and browsing for
    MfPL> the right buffers is not faster than marking the files I want and
    MfPL> hitting M-x ediff RET RET RET.

    MK> However, I am open to the idea of looking at patches that
    MK> implement better heuristics.

    MfPL> The following works for me with the added bonus that I don't have to
    MfPL> confirm the files I already marked.  Maybe this would be better
    MfPL> implemented as a seperate dired function (dired-do-ediff?), or maybe
    MfPL> I'm the only one doing this type thing and it should simply go in my
    MfPL> init file.

    MfPL> diff -w --context=1 "d:/src/ediff.el" "e:/cvs/emacs/lisp/ediff.el"
    MfPL> *** d:/src/ediff.el   Mon Jul 26 14:24:15 2004
    MfPL> --- e:/cvs/emacs/lisp/ediff.el        Sat Jun  5 21:44:14 2004
    MfPL> ***************
    MfPL> *** 196,200 ****
    MfPL> (interactive
    MfPL> -    (if (and (eq major-mode 'dired-mode)
    MfPL> -             (> (length (dired-get-marked-files)) 1))
    MfPL> -        (list (car (dired-get-marked-files)) (car (cdr 
(dired-get-marked-files))))
    MfPL> (let ((dir-A (if ediff-use-last-dir
    MfPL> --- 196,197 ----
    MfPL> ***************
    MfPL> *** 221,223 ****
    MfPL> (ediff-get-default-file-name f 1)))
    MfPL> !              ))))
    MfPL> (ediff-files-internal file-A
    MfPL> --- 218,220 ----
    MfPL> (ediff-get-default-file-name f 1)))
    MfPL> !        )))
    MfPL> (ediff-files-internal file-A

    MfPL> Diff finished.  Mon Jul 26 14:57:34 2004