emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

windmove and the minibuffer: PATCH


From: Jesse Byler
Subject: windmove and the minibuffer: PATCH
Date: Wed, 04 Aug 2004 14:14:25 -0400

The windmove package has for some time been unable to access the
minibuffer; see previous report at 
http://lists.gnu.org/archive/html/emacs-devel/2003-05/msg00704.html

I traced this bug to a small logic error in windmove-other-window-loc. 
This function uses window-edges to find the corners of a window. 
According to the documentation for window-edges, however, the right and
bottom coordinates it returns are actually "one more than the rightmost
column occupied by window" and "one more than the bottommost row
occupied by window", and windmove-other-window-loc does not take this
into account.  The resulting off-by-one error is not noticeable in most
cases because most windows are wider and taller than one character
coordinate, so windmove-other-window-loc still returns a coordinate in
the desired window.  In the case of the minibuffer, however, the off by
one error can overshoot the minibuffer entirely.

I have attached a small patch to the windmove-other-window-loc function
in CVS emacs which fixes the problem.  If there are copyright issues /
etc. that prevent the emacs team from checking in my patch, someone else
can implement the same fix quite easily: just change the function to
compute x1-1 in place of x1 and y1-1 in place of y1.

Thanks,
Jesse
-----

The information contained in this electronic mail
and any attached document is the confidential and
proprietary business information of Forum Systems,
Inc. It is intended solely for the addressed
recipient listed above. It may not be distributed
in any manner without the express written consent
of Forum Systems, Inc.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]