Re: substitute-key-definition problem with menus in Emacs 21

[Richard Stallman]

    In any case, isn't your definition of substitute-key-definition equivalent 
to:

    (defun substitute-key-definition (olddef newdef keymap &optional oldmap 
prefix)
      ...
      (or prefix (setq prefix ""))
      (let* ((scan (or oldmap keymap))
             (prefix1 (vconcat prefix [nil]))
             (key-substitution-in-progress
              (cons scan key-substitution-in-progress)))
        ;; Scan OLDMAP, finding each char or event-symbol that
        ;; has any definition, and act on it with hack-key.
        (map-keymap

I just fixed the bug.  If this simplification works, go ahead
and install it.

A comment in the code suggests in some cases this might have
bad results with chartables.  Specifically when the chartable
has an entry that applies to an entire character set.  It might
get replaced with a lot of entries for individual characters.
I am not sure if this is really possible, though.

The existing code might also have that problem.  To avoid the problem
might require more work on the chartable case.