Re: Ediff frequently crashes emacs.

[Peter Seibel]

YAMAMOTO Mitsuharu <address@hidden> writes:

>>>>>> On Thu, 28 Oct 2004 22:28:54 -0700, Peter Seibel <address@hidden> said:
>
>> At seemingly random times executing any ediff command such as by
>> hitting 'n' or 'p' or (this latest time) 'b' to move a change from
>> buffer b to buffer a, it will cause emacs to exit with no
>> warning. (I have confirm-kill-emacs set to y-or-n-p). Othertimes it
>> won't crash emacs but instead will seemingly hang it--my cursor
>> changes to a watch and emacs does not respond to C-g or 'q' to quit
>> ediff. I've tried to reproduce this by ediffing the same files and
>> it doesn't always happen.
>
> Does the following patch make any difference?

I'll let you know after I've had a chance to use a patched version for
a while. Thanks.

-Peter

>
>                                    YAMAMOTO Mitsuharu
>                               address@hidden
>
> Index: src/callproc.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/callproc.c,v
> retrieving revision 1.204
> diff -c -r1.204 callproc.c
> *** src/callproc.c    13 Oct 2004 09:50:36 -0000      1.204
> --- src/callproc.c    28 Oct 2004 08:24:47 -0000
> ***************
> *** 83,88 ****
> --- 83,89 ----
>   #include "process.h"
>   #include "syssignal.h"
>   #include "systty.h"
> + #include "blockinput.h"
>   
>   #ifdef MSDOS
>   #include "msdos.h"
> ***************
> *** 624,629 ****
> --- 625,632 ----
>       pid = child_setup (filefd, fd1, fd_error, (char **) new_argv,
>                      0, current_dir);
>   #else  /* not WINDOWSNT */
> +     BLOCK_INPUT;
> + 
>       pid = vfork ();
>   
>       if (pid == 0)
> ***************
> *** 641,646 ****
> --- 644,651 ----
>       child_setup (filefd, fd1, fd_error, (char **) new_argv,
>                    0, current_dir);
>         }
> + 
> +     UNBLOCK_INPUT;
>   #endif /* not WINDOWSNT */
>   
>       /* The MSDOS case did this already.  */
>

-- 
Peter Seibel                                      address@hidden

         Lisp is the red pill. -- John Fraser, comp.lang.lisp