Re: replace history is broken for empty strings and/or duplicate entries

[Juri Linkov]

Richard Stallman <address@hidden> writes:
> I fixed this, thanks.

Unfortunately, all problems are not fixed yet.
There are some I can find now:

1. When the user types RET to repeat the last search, an empty string
is added to the history:

M-x replace-string RET {no history         } x RET y RET
M-x replace-string RET {history: x -> y    } RET
M-x replace-string RET {history: y ->      } (!)

This is easy to fix in `query-replace-read-from'.

2. When the user for various reasons interrupts reading TO-STRING,
FROM-STRING still remains in the history:

M-x replace-string RET {no history         } x RET y RET
M-x replace-string RET {history: x -> y    } z RET C-g
M-x replace-string RET {history: y -> z    } (!)

There is no simple solution since the user might want to retrieve
the last entered FROM-STRING from the history with M-p on the next
invocation of replace-string.

-- 
Juri Linkov
http://www.jurta.org/emacs/