Re: Problems with edebug-set-conditional-breakpoint.

[Juri Linkov]

Matt Hodges <address@hidden> writes:
> My only minor comment is that if read-expression-history is the same
> between invocations of edebug-set-conditional-breakpoint, such that
> (format "%s" edebug-break-condition) and (car read-expression-history)
> are equal, then two presses of M-p are required to get a different
> entry. This feels a bit strange, but maybe that's just me -- I do
> think presenting a default value is a good idea, though.

It's possible to use the following code in place of the
`read-expression-history' argument:

             (if (equal (car read-expression-history)
                        (format "%s" edebug-break-condition))
                 '(read-expression-history . 1)
               'read-expression-history)

However, I doubt that similar code should be duplicated everywhere
where an initial content is specified for `read-from-minibuffer'.
I think that C implementation of `read-from-minibuffer' should handle
such situations and set the history position to 1 when initial
contents is equal to the last history element.

-- 
Juri Linkov
http://www.jurta.org/emacs/