emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

w32-win.el's xw-defined-colors should not use `message'


From: Drew Adams
Subject: w32-win.el's xw-defined-colors should not use `message'
Date: Fri, 21 Jan 2005 22:07:06 -0800

Function `xw-defined-colors' is defined in these places, independently:

 - w32-win.el
 - mac-win.el
 - x-win.el

In w32-win.el only, there is this inappropriate call to message:

 (message "Defining colors...")

The other versions of `xw-defined-colors' do not have a call to
`message'. The function is not interactive, and there is no reason for
the message.

This call to `message' should be removed. It is especially annoying
when the function gets called from an idle-timer hook - the message
appears inexplicably, from nowhere.


In GNU Emacs 21.3.50.1 (i386-mingw-nt5.1.2600)
 of 2004-07-26 on BERATUNG4
configured using `configure --with-gcc
(3.3) --cflags -I../../jpeg-6b-1/include -I../../libpng-1.2.4-1/include -I..
/../tiff-3.5.7/include -I../../xpm-nox-4.2.0/include -I../../zlib-1.1.4-1/in
clude'





reply via email to

[Prev in Thread] Current Thread [Next in Thread]