Re: gdb emacs reporting 'Function "x_error_quitter" not defined' [includes PATCH]

[Andrew M. Scott]

>>>>> "Eli" == Eli Zaretskii <address@hidden> writes:

    >> From: "Andrew M. Scott" <address@hidden>
    >> Date: Thu, 27 Jan 2005 13:44:40 -0700
    >> Cc: address@hidden, address@hidden
    >> 
    >> gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. 
-I/stor/garray/src/savannah/emacs/src -D_BSD_SOURCE 
-I/usr/intel/pkgs/X11/R6.7.0/include -g -O2 
/stor/garray/src/savannah/emacs/src/xterm.c
    >> /stor/garray/src/savannah/emacs/src/xterm.c:7794: error: conflicting 
types for 'x_error_quitter'
    >> /stor/garray/src/savannah/emacs/src/xterm.c:7780: error: previous 
implicit declaration of 'x_error_quitter' was here
    >> gmake[1]: *** [xterm.o] Error 1
    >> 
    >> 2. If I apply the xterm.c patch (below) posted by Gary Lawrence Murphy 
to gnu.emacs.bug on Jan 27, 2005
    >> then the x_error_quitter breakpoint works correctly on *both* gcc 3.3.2 
*and* 3.4.2 builds
    >> of CVS Emacs-21.3.50 under gdb-6.3.

    Eli> A better change was already committed to CVS (by Stefan): it puts a
    Eli> prototype of x_error_quitter before it is used.

Stefan's Jan 27, 2005 xterm.c patch does not allow a breakpoint on 
x_error_quitter when compiled with gcc-3.4.2
$  nm xterm.o | grep quitter
0000c530 t x_io_error_quitter

whereas Gary Lawrence Murphy's patch 
(http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-01/msg00425.html) 
does:

gcc-3.4.2:
$ nm xterm.o | grep quitter
0000c900 T x_error_quitter
0000c5f0 t x_io_error_quitter

gcc-3.3.2
$ nm xterm.o | grep quitter
000095b0 T x_error_quitter
00009630 t x_io_error_quitter