emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Enabling xassert unconditionally causes a problem in xfaces.c.


From: Lute Kamstra
Subject: Enabling xassert unconditionally causes a problem in xfaces.c.
Date: Thu, 03 Feb 2005 11:13:35 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux)

Due to this change:

2005-02-02  Miles Bader  <address@hidden>

        * dispextern.h (xassert): Enable unconditionally.

xfaces.c doesn't compile anymore:

  gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. 
-I/soft/careful/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g -O2 xfaces.c
  xfaces.c: In function `x_free_gc':
  xfaces.c:741: error: `ngcs' undeclared (first use in this function)
  xfaces.c:741: error: (Each undeclared identifier is reported only once
  xfaces.c:741: error: for each function it appears in.)

ngcs is declared behind an #if GLYPH_DEBUG and is used in x_free_gc
within an xassert.  xassert used to be void when GLYPH_DEBUG was not
set, but the above change enables xassert unconditionally thus causing
a problem.

Should ngcs be declared unconditionally as well or should its use in
x_free_gc be put within an IF_DEBUG?

Lute.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]