Re: Abort when no X font resources are set.

[Aidan Kehoe]

 Ar an seachtú lá is fiche de mí Feabhra, scríobh Jan D.: 

 > I still can't reproduce this on any OS.  Are you soure you don't have 
 > any Emacs resources in .Xdefaults or /etc/X11/app-defaults or 
 > /usr/X11R6/lib/X11/app-defaults or /usr/lib/X11/app-defaults?  It looks 
 > like the default fontset does not exist on your computer.

Stallman pointed Kenichi Handa towards the issue; here’s the end of my
correspondence with Kenichi. Hope it clears up any confusion.

From Aidan Kehoe <address@hidden>
To: Kenichi Handa <address@hidden>
Subject: Re: fontset-related bug 
Date: Thu, 24 Feb 2005 03:17:01 +0000

Hi, Kenichi

 Ar an ceathrú lá is fiche de mí Feabhra, scríobh Kenichi Handa:  
 
 > Please set break point at the function fontset_font_pattern, rerun Emacs, 
 > and when it stopped at fontset_font_pattern, run the code one line by 
 > one, and see why it returns Qnil. 
 
I don’t have the resolution-specific XFree86 directories in my font path, so
the "-adobe-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-1" font wasn’t
available. There are plenty of other courier fonts available in the XFree86
misc/ directory, though, so taking out the foundry specification stops the
crash--the patch that stops it crashing for me is below. 

Of course, some more informative output to standard error when the program
can’t load its needed font is probably the better way to tackle the problem,
long-term.

Best regards, 

        - Aidan


src/ChangeLog addition:

2005-02-24  Aidan Kehoe  <address@hidden>

        * fontset.c (syms_of_fontset): Don't require that the fallback
        Courier font have adobe as its foundry.


GNU Emacs Trunk source patch:
Diff command:   cvs -q diff -u
Files affected: src/fontset.c

Index: src/fontset.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fontset.c,v
retrieving revision 1.92
diff -u -u -r1.92 fontset.c
--- src/fontset.c       8 Nov 2004 00:38:26 -0000       1.92
+++ src/fontset.c       24 Feb 2005 02:05:36 -0000
@@ -1638,7 +1638,7 @@
 #else
   FONTSET_ASCII (Vdefault_fontset)
     = Fcons (make_number (0),
-            build_string 
("-adobe-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-1"));
+            build_string ("-*-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-1"));
 #endif
   AREF (Vfontset_table, 0) = Vdefault_fontset;
   next_fontset_id = 1;

-- 
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien