Re: diary-redraw-calendar clobbers point in diary-file buffer.

[Matt Hodges]

>>>>> Glenn Morris writes:

 > OK, so when generate-calendar erases the calendar buffer, window
 > point gets set to 1 and never moves back. You explictly set it back
 > to the cursor-date position. Isn't this purely cosmetic though?

Yes, this is what I was trying to fix with the patch.

 > I don't see how it could ever cause a bug of the recently reported
 > kind. All lisp commands will use the buffer point rather than the
 > window point.  Someone would have to select the calendar window
 > part-way through an operation for this to cause a problem. I don't
 > see any instance in calendar.el that could do that.

I don't see this bug any more.

 > And (trivially) what if the calendar window is in a different
 > frame, or there is more than one calendar window?

Indeed these are situations that you may want to consider and cater
for.  It would be easy to sync all the relevant window points, if this
is thought best.

 > This function is only called when the diary is saved after, eg, "i
 > d".  So I also don't see how this function could have caused any
 > kind of bug at calendar start-up.

Agreed.  But some mechanism is still required to stop point being
clobbered in the diary-file buffer when saving, and
write-contents-functions contains diary-redraw-calendar.

Thanks,

Matt