file-error during recursive dired-do-copy of a relative symlink

[Andrew M. Scott]

Recursive dired-do-copy isn't handling *relative* symlink copying
properly, resulting in error:
(file-error Non-regular file is a directory ... )

% emacs -q -no-site-file &

(setq dired-recursive-copies  'top)
(setq dired-dwim-target t)
(setq dired-listing-switches "-alFt")

Startup Dired, with source directory in top buffer, target directory
in lower buffer 

1. Relative symlink target address - unexpected behavior

   dired-do-copy on a symlink *relative* target address
   (/stor/garray/src/test2) didn't copy correctly to the 
   target directory (/stor/garray/src/test4). It created the 
   /stor/garray/src/test4/test directory but did not copy
   either the 21.4 directory or 21.3-> 21.4 symlink into it.

  Source directory:

  /stor/garray/src/test:
  lrwxrwxrwx   1 user garray     4 2005-04-19 10:36 21.3 -> 21.4/
  drwxr-sr-x   2 user garray  4096 2005-04-19 10:36 21.4/

  Target directory:
  /stor/garray/src/test4:
  drwxr-sr-x   2 user garray  4096 2005-04-19 10:59 test/

  /stor/garray/src/test4/test:
  drwxr-sr-x  2 user garray 4096 2005-04-19 10:59 ./
  drwxr-sr-x  3 user garray 4096 2005-04-19 10:59 ../

*Messages* buffer contents:
(No files need saving)
Copy [-p] `/stor/garray/src/test' to `/stor/garray/src/test2/test' failed:
(file-error Non-regular file is a directory /stor/garray/src/test/21.3)

2. Absolute symlink target address example - works properly

  dired-do-copy on a symlink that pointed to an *absolute* directory
  (/stor/garray/src/test2  copied correctly to a target directory
  (/stor/garray/src/test5) 

  Source directory:
  /stor/garray/src/test2:
  lrwxrwxrwx   1 user garray    25 2005-04-19 11:02 setnu.el -> 
/stor/garray/src/setnu.el

  Target directory:
  /stor/garray/src/test5/test2:
  -rw-r--r--  1 user garray 16650 2005-04-18 16:23 setnu.el



In GNU Emacs 22.0.50.1 (i686-pc-linux-gnu, X toolkit)
 of 2005-04-15 on chlr4920
Distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure '--prefix=/stor/garray/linux' 
'--x-includes=/usr/intel/pkgs/X11/R6.7.0/include' 
'--x-libraries=/usr/intel/pkgs/X11/R6.7.0/lib' 'CC=gcc' 'CFLAGS=-O2 
-I/usr/intel/pkgs/X11/R6.7.0/include -L/usr/intel/pkgs/X11/R6.7.0/lib 
-I/usr/intel/pkgs/zlib/1.2.1/include -L/usr/intel/pkgs/zlib/1.2.1/lib  
-I/usr/intel/pkgs/ncurses/5.4/include -L/usr/intel/pkgs/ncurses/5.4/lib 
-I/usr/intel/pkgs/libungif/4.1.3/include -L/usr/intel/pkgs/libungif/4.1.3/lib 
-I/usr/intel/pkgs/libpng/1.0.16rc1/include 
-L/usr/intel/pkgs/libpng/1.0.16rc1/lib -I/usr/intel/pkgs/jpeg/6b/include 
-L/usr/intel/pkgs/jpeg/6b/lib' 'LDFLAGS=-L/usr/intel/pkgs/X11/R6.7.0/lib 
-L/usr/intel/pkgs/zlib/1.2.1/lib -L/usr/intel/pkgs/ncurses/5.4/lib 
-L/usr/intel/pkgs/libungif/4.1.3/lib -L/usr/intel/pkgs/libpng/1.0.16rc1/lib 
-L/usr/intel/pkgs/jpeg/6b/lib 
-Wl,-rpath=/usr/intel/pkgs/X11/R6.7.0/lib:/usr/intel/pkgs/zlib/1.2.1/lib:/usr/intel/pkgs/ncurses/5.4/lib:/usr/intel/pkgs/libungif/4.1.3/lib:/usr/intel/pkgs/libpng/1.0.16rc1/lib:/usr/intel/pkgs/jpeg/6b/lib''

Important settings:
  value of $LC_ALL: en_US
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  file-name-shadow-mode: t
  auto-image-file-mode: t
  msb-mode: t
  icomplete-mode: t
  auto-compression-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  next-error-follow-minor-mode:  Fol