Makefile font locking errors

[Ralf Angeli]

The new font locking code for Makefile mode produces a lot of errors
(see below in "Recent messages") because of the element

 (nil
  (0 nil))

in `font-lock-keywords' which corresponds to

    ,(if negation
         `(,negation (1 font-lock-negation-char-face prepend)
                     (2 font-lock-negation-char-face prepend t)))

in make-mode.el.

In addition the resulting fontification is quite erroneous and does
not seem to serve a sensible purpose.  What is the rationale for
giving most of the code preceded by whitespace a pink background?

This is especially odd in cases like (taken from lisp/Makefile)

AUTOGENEL = loaddefs.el \
        cus-load.el \
        finder-inf.el \
        subdirs.el \
        eshell/esh-groups.el

where the background of the first line is unchanged and only the
following lines have a pink background.

Taking lisp/Makefile as an example again, there are a lot of lines
which seem to be underlined for no good reason; for example in the
$(lisp)/loaddefs.el target.

It would probably also be a good idea to do such changes more
carefully when it comes to changing face properties.  For example, why
was it necessary to change the fontification of make targets so
drastically?


In GNU Emacs 22.0.50.1 (i386-unknown-freebsd5.4, GTK+ Version 2.6.7)
 of 2005-05-14 on neutrino.iwi.uni-sb.de
Distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure '--with-gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.ISO8859-1
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Major mode: Makefile

Minor modes in effect:
  desktop-save-mode: t
  display-time-mode: t
  iswitchb-mode: t
  show-paren-mode: t
  encoded-kbd-mode: t
  mouse-wheel-mode: t
  auto-compression-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  next-error-follow-minor-mode:  Fol

Recent input:
<return> C-x C-f <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> e m 
<tab> M a k <tab> <return> <next> <next> <next> <next> 
<next> <next> <up> <up> <up> <up> <next> <next> <next> 
<next> <next> <next> <next> <next> <next> <next> <next> 
<next> <next> <prior> <prior> <prior> <prior> <prior> 
<prior> <prior> <prior> <prior> <prior> <prior> <prior> 
<prior> <prior> <prior> <prior> <prior> <prior> <prior> 
<prior> <prior> <prior> <prior> <prior> <prior> <prior> 
C-x C-f l i s <tab> / M a k <tab> <return> <next> <prior> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> x M-x r e p o r <tab> <return>

Recent messages:
Mark set
Mark saved where search started
Note: file is write protected
Error during redisplay: (void-function nil) [57 times]
call-interactively: End of buffer
call-interactively: Beginning of buffer [8 times]
Note: file is write protected
Error during redisplay: (void-function nil) [6 times]
Buffer is read-only: #<buffer Makefile<2>>
Loading emacsbug...done