emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ding - too often (OS X and in general)


From: Kim F. Storm
Subject: Re: ding - too often (OS X and in general)
Date: Tue, 24 May 2005 09:54:19 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Richard Stallman <address@hidden> writes:

> Quitting rings the bell because you do it with the bell character,
> C-g.

That's a relic from ASCII and TTY days.

These days it really doesn't make sense on non-TTY platforms -- it's
more like a bad joke.

>       Also, it works by causing something almost indistiguishable from
> an error.

"almost" means it would not be impossible to distinguish.

Here is a trivial patch to illustrate that it can be done.
(I would use a different method in a real fix).

*** keyboard.c  19 May 2005 09:35:20 +0200      1.825
--- keyboard.c  24 May 2005 09:50:17 +0200      
***************
*** 1246,1252 ****
      {
        Fdiscard_input ();
        message_log_maybe_newline ();
!       bitch_at_user ();
        stream = Qt;
      }
  
--- 1246,1254 ----
      {
        Fdiscard_input ();
        message_log_maybe_newline ();
!       if (EQ (XCAR (data), Qquit)
!         && !EQ (last_command_char, make_number (7)))  /* C-g */
!       bitch_at_user ();
        stream = Qt;
      }
  

> I see no reason to change this.

WDOT?

--
Kim F. Storm <address@hidden> http://www.cua.dk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]