Why does mark-included-diary-files call kill-buffer?

[Stephen Berman]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the address@hidden mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


I have a file that I #include in ~/diary.  When I edit the included
file and then call save-buffer on it, or if I call calendar before
saving the edited file, I get asked "Buffer XXX modified; kill
anyway?" (XXX is the included file).  I debugged this to down
mark-included-diary-files, which I have added to
mark-diary-entries-hook and which calls kill-buffer on the included
file.  If I remove that function call, as below, then I can save the
included file or call calendar without getting the, for these
situations inappropriate, question.  I don't see why kill-buffer is
called here, and I haven't yet encountered any adverse effects of
removing it, but I may be overlooking something.  If so, maybe the
call to kill-buffer can be conditioned to avoid the inappropriate
behavior I've observed.

*** /home/steve/cvsroot/emacs/lisp/calendar/diary-lib.el.~1.94.~        
2005-05-17 12:58:49.000000000 +0200
--- /home/steve/cvsroot/emacs/lisp/calendar/diary-lib.el        2005-05-29 
00:56:58.000000000 +0200
***************
*** 1056,1064 ****
            (mark-diary-entries-hook 'mark-included-diary-files))
        (if (file-exists-p diary-file)
            (if (file-readable-p diary-file)
!               (progn
!                 (mark-diary-entries)
!                 (kill-buffer (find-buffer-visiting diary-file)))
              (beep)
              (message "Can't read included diary file %s" diary-file)
              (sleep-for 2))
--- 1056,1062 ----
            (mark-diary-entries-hook 'mark-included-diary-files))
        (if (file-exists-p diary-file)
            (if (file-readable-p diary-file)
!               (mark-diary-entries)
              (beep)
              (message "Can't read included diary file %s" diary-file)
              (sleep-for 2))



In GNU Emacs 22.0.50.12 (i686-pc-linux-gnu, GTK+ Version 2.6.4)
 of 2005-05-20 on escher
Distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
  tabbar-mode: t
  recentf-mode: t
  show-paren-mode: t
  display-time-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: identity
  next-error-follow-minor-mode:  Fol

Recent input:
<down-mouse-5> <mouse-5> <down-mouse-5> <mouse-5> <down-mouse-1> 
<mouse-1> <double-down-mouse-1> <double-mouse-1> <down-mouse-1> 
<mouse-1> <double-down-mouse-1> <double-mouse-1> <triple-down-mouse-1> 
<triple-mouse-1> <down-mouse-3> <mouse-3> <down-mouse-1> 
<mouse-1> <double-down-mouse-1> <double-mouse-1> <triple-down-mouse-1> 
<triple-mouse-1> <down-mouse-3> <mouse-3> <down-mouse-1> 
<mouse-1> <tab> C-x C-s M-x e d i f f <return> <return> 
d i <tab> <tab> <tab> <M-backspace> <backspace> ~ <tab> 
<backspace> <tab> <tab> <tab> ~ <tab> <backspace> <tab> 
<tab> C-g C-x d <return> <f11> <return> M-x <up> <return> 
<return> <up> . <tab> <return> D <switch-frame> q y 
M-x <up> <return> <return> <up> <up> <up> <M-backspace> 
<M-backspace> <backspace> <backspace> <return> D <switch-frame> 
<f1> <switch-frame> <select-window> <help-echo> <f1> 
M-x r e p o r <tab> <return>

Recent messages:
Fontifying *ediff-custom-diff*... (regexps...............)
Quit this Ediff session? (y or n) 
Reading file /home/steve/cvsroot/emacs/lisp/calendar/diary-lib.el.~1.94.~ ... 
Reading file /home/steve/cvsroot/emacs/lisp/calendar/diary-lib.el ... 
Computing differences between diary-lib.el.~1.94.~ and diary-lib.el ...
Buffer A: Processing difference region 0 of 1
Buffer B: Processing difference region 0 of 1
Processing difference regions ... done
Fontifying *ediff-custom-diff*... (regexps...............)
Loading emacsbug...done