[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: adaptive-fill bug?
From: |
Stefan Monnier |
Subject: |
Re: adaptive-fill bug? |
Date: |
Fri, 10 Jun 2005 10:30:07 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
> Could you explain the overall idea of this patch?
The patch makes two changes:
1. it removes the (looking-at paragraph-start) check on the second line of
a paragraph.
2. it rejects fill-prefixes guessed by adaptive-fill-mode if they are longer
than a line of text (longer than the difference between fill-column and
left-margin).
The second part is the crucial one and should be 100% uncontroversial.
Such long prefixes don't make any sense anyway and are (in my experience)
always the result of matching a long line of dashes. Also such a long
prefix makes the subsequent paragraph-fill fail miserably because it can
never find a place the cut the line(s) to stay within the fill-column.
The first part should be harmless as well: such a check used to be done on
both the first and the second line of a paragraph. I removed the check on
the first line several years ago because it introduced a bug, and moved the
paragraph-start check further down, just before returning. This late-check
also makes the second check unnecessary.
> Changes in the heuristics of adaptive-fill-mode are very risky.
I should know. I'm the one who made each and every change in that area in
the last 3 years.
> Please don't go ahead and install it before we have this discussion.
Of course,
Stefan
- adaptive-fill bug?, Katsumi Yamaoka, 2005/06/07
- Re: adaptive-fill bug?, Katsumi Yamaoka, 2005/06/07
- Re: adaptive-fill bug?, Katsumi Yamaoka, 2005/06/09
- Re: adaptive-fill bug?, Stefan Monnier, 2005/06/09
- Re: adaptive-fill bug?, Katsumi Yamaoka, 2005/06/09
- Re: adaptive-fill bug?, Richard Stallman, 2005/06/10
- Re: adaptive-fill bug?,
Stefan Monnier <=
- Re: adaptive-fill bug?, Richard Stallman, 2005/06/11
- Re: adaptive-fill bug?, Stefan Monnier, 2005/06/12
- Re: adaptive-fill bug?, Richard Stallman, 2005/06/13
- Re: adaptive-fill bug?, Stefan Monnier, 2005/06/13
- Re: adaptive-fill bug?, Katsumi Yamaoka, 2005/06/13