RE: flymake minor mode incompatible with cvs version control log entry

[Ortmann, Daniel]

I also must have misread.  I apparently did not read the flymake documentation 
well enough, assuming it was a text mode grammar checker related to flyspell.

Thank you for pointing out my misunderstanding.  I will rt*m once again.

There still may be a bug there somewhere, but it is non-critical for me.

Let me know if I may help (sans major time investment).

Thanks for the clues!

--
address@hidden
Cardiac Rhythm Management
CRM Software Development & Technology
763-514-8230 (w) 763-514-3192 (f) 612-518-3147 (c)
address@hidden 651-455-1442 (h)


-----Original Message-----
From: Stefan Monnier [mailto:address@hidden
Sent: Monday, June 13, 2005 5:09 PM
To: Ortmann, Daniel
Cc: address@hidden
Subject: Re: flymake minor mode incompatible with cvs version control
log entry


> I have attached the trace.  Is this sufficient?

Sorry, I misread.  I though you said flyspell, not flymake.
What sense does it make to place flymake on text-mode-hook?
Could you explain your use case?


        Stefan


> --
> address@hidden
> Cardiac Rhythm Management
> CRM Software Development & Technology
> 763-514-8230 (w) 763-514-3192 (f) 612-518-3147 (c)
> address@hidden 651-455-1442 (h)


> -----Original Message-----
> From: Stefan Monnier [mailto:address@hidden
> Sent: Monday, June 13, 2005 2:02 PM
> To: Ortmann, Daniel
> Cc: address@hidden
> Subject: Re: flymake minor mode incompatible with cvs version control
> log entry


>> When flymake mode was added to the text-mode-hook using emacs
>> customization, I was unable to enter a new revision in a cvs version
>> controlled file when the filename contained a '-' character inside the
>> filename.  The problem filename was "cvschanges-rewrite.py".

>> The file was already under CVS version control.  CVS worked fine from the
>> command line.  I made a file change and pressed control x v v.  The result
>> was that I received an error message, apparently from flymake, claiming
>> the filename was invalid.

>> The workaround is to remove flymake mode from the text-mode-hook.

>> (I have not dug further into the actual source of the error.)

> Please dig deeper.  This is a bug.
> Set Options=>Enter Debugger on Error, reproduce the bug, show us
> the backtrace.  Or if you don't get a backtrace, give us a recipe to
> reproduce the problem, starting from "emacs -q --no-site-file".


>         Stefan
> Debugger entered--Lisp error: (error "Invalid file-name")
>   signal(error ("Invalid file-name"))
>   error("Invalid file-name")
>   flymake-get-file-name-mode-and-masks(nil)
>   flymake-get-init-function(nil)
>   flymake-can-syntax-check-file(nil)
>   flymake-mode()
>   run-hooks(text-mode-hook log-edit-mode-hook)
>   apply(run-hooks (text-mode-hook log-edit-mode-hook))
>   run-mode-hooks(log-edit-mode-hook)
>   log-edit-mode()
>   log-edit(vc-finish-logentry nil (lambda nil (quote 
> ("cvschanges-rewrite.py"))))
>   vc-log-edit("/user/ortmad1/sandbox/releaseaudit/cvschanges-rewrite.py")
>   vc-start-entry("/user/ortmad1/sandbox/releaseaudit/cvschanges-rewrite.py" 
> nil nil nil "Enter a change comment." #[(file rev comment) "\"ˆ        
> ƒ    \"„Cr!†pqˆ!
        %ˆ!ˆ)!8BBB\"ˆ)\"‡" [file comment vc-touched-properties rev 
message "Checking in %s..." string-match "[^    \n ]" "*** empty log message 
***" t get-file-buffer vc-call-backend vc-backend checkin 
vc-delete-automatic-version-backups mapcar #[... "address@hidden>?…
\f\"    A#)‡" [setting property vc-touched-properties file 
vc-file-prop-obarray put intern] 5] (vc-state . up-to-date) vc-checkout-time 5 
file-attributes (...) "Checking in %s...done"] 7] vc-checkin-hook)
>   vc-checkin("/user/ortmad1/sandbox/releaseaudit/cvschanges-rewrite.py" nil 
> nil)
>   
> vc-next-action-on-file("/user/ortmad1/sandbox/releaseaudit/cvschanges-rewrite.py"
>  nil)
>   byte-code("ƒ1 !ˆ   #˜ƒ!‰#ˆ‚+‰‰‰&ˆ\"ˆ)
ƒ<
!ˆ‚1\fƒE\f
\"‡ \"‡" [vc-dired-mode files vc-dired-window-configuration vc-parent-buffer 
buffer-file-name verbose dired-get-marked-files make-local-variable 
current-window-configuration mapconcat #[(f) "   !)=„
‡‡" [f file vc-state up-to-date "@" ""] 2] "" "" vc-next-action-dired nil 
"dummy" vc-start-entry "Enter a change comment for the marked files." throw 
nogo pop-to-buffer vc-next-action-on-file error "Buffer %s is not associated 
with a file" buffer-name] 7)
>   vc-next-action(nil)
>   call-interactively(vc-next-action)