emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Infitite recursion in indentation


From: Stefan Monnier
Subject: Re: Infitite recursion in indentation
Date: Wed, 29 Jun 2005 02:43:29 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> Does this patch give good results?
> *** lisp-mode.el      23 Jun 2005 17:28:14 -0400      1.177
> --- lisp-mode.el      25 Jun 2005 01:10:21 -0400      
> ***************
> *** 202,207 ****
> --- 202,209 ----
>     (setq comment-column 40)
>     ;; Don't get confused by `;' in doc strings when paragraph-filling.
>     (set (make-local-variable 'comment-use-global-state) t)
> +   (make-local-variable 'comment-indent-function)
> +   (setq comment-indent-function 'lisp-comment-indent)
>     (make-local-variable 'imenu-generic-expression)
>     (setq imenu-generic-expression lisp-imenu-generic-expression)
>     (make-local-variable 'multibyte-syntax-as-symbol)

It has the disadvantage of hiding the actual bug.
I believe that the patch below is preferable,


        Stefan


Index: lisp/newcomment.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/newcomment.el,v
retrieving revision 1.83
diff -u -r1.83 newcomment.el
--- lisp/newcomment.el  19 May 2005 19:06:18 -0000      1.83
+++ lisp/newcomment.el  29 Jun 2005 06:42:14 -0000
@@ -502,7 +502,7 @@
           (or (match-end 1) (/= (current-column) (current-indentation))))
       0
     (when (or (/= (current-column) (current-indentation))
-             (and (> comment-add 0) (looking-at "\\s<\\S<")))
+             (and (> comment-add 0) (looking-at "\\s<\\(\\S<\\|\\'\\)")))
       comment-column)))
 
 ;;;###autoload




reply via email to

[Prev in Thread] Current Thread [Next in Thread]