emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: descibe-mode problem


From: Katsumi Yamaoka
Subject: Re: descibe-mode problem
Date: Tue, 12 Jul 2005 08:39:38 +0900
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>>>>> In [semi-gnus-ja : No.13861] Richard M. Stallman wrote:

>     I report this problem to semi-gnus-ja mailing-list.  Yamaoka-san who
>     is one of Gnus developer said it seem to be Emacs's problem: Though
>     add-minor-mode's 5th argument in the definition of gnus-topic-mode
>     is lambda expression, describe-mode check it by fboundp.

> The 5th arg should be the same as the 1st arg.

I'm confused.  That is the same as the case where the 5th arg is
omitted.  Does it mean that to specify the 5th arg of
`add-minor-mode' is meaningless?  If it is true, I'll scan Gnus
and remove such ones.  Actually, I couldn't find any function
which refers the `:minor-mode-function' property.

Otherwise, the following patch avoids that error at least.

*** help.el~    Tue Jul  5 21:54:43 2005
--- help.el     Mon Jul 11 23:38:12 2005
***************
*** 730,736 ****
        (dolist (mode minor-mode-list)
          ;; Document a minor mode if it is listed in minor-mode-alist,
          ;; non-nil, and has a function definition.
!         (let ((fmode (or (get mode :minor-mode-function) mode)))
            (and (boundp mode) (symbol-value mode)
                 (fboundp fmode)
                 (let ((pretty-minor-mode
--- 730,741 ----
        (dolist (mode minor-mode-list)
          ;; Document a minor mode if it is listed in minor-mode-alist,
          ;; non-nil, and has a function definition.
!         (let ((fmode (get mode :minor-mode-function)))
!           ;; FIXME: Currently it works properly only when the `fmode'
!           ;; function specified as the 5th argument of `add-minor-mode'
!           ;; is a function symbol.
!           (unless (and fmode (symbolp fmode))
!             (setq fmode mode))
            (and (boundp mode) (symbol-value mode)
                 (fboundp fmode)
                 (let ((pretty-minor-mode




reply via email to

[Prev in Thread] Current Thread [Next in Thread]