[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rxvt vs xterm keybindings
From: |
Dan Nicolaescu |
Subject: |
Re: rxvt vs xterm keybindings |
Date: |
Tue, 26 Jul 2005 11:30:54 -0700 |
Eli Zaretskii <address@hidden> writes:
> > From: Dan Nicolaescu <address@hidden>
> > Date: Tue, 26 Jul 2005 10:20:06 -0700
> > Cc: address@hidden
> >
> > ! (when term
> > ! ;; The terminal file has been loaded, now call the terminal
> > ! ;; specific initialization function.
> > ! (funcall (intern (concat "terminal-init-" term))))))
>
> I suggest to call the function only if it's fboundp. It's IMHO unsafe
> to jump into the blue without checking.
Agreed.
Is this version OK to commit?
*** startup.el 22 Jul 2005 20:17:09 -0700 1.369
--- startup.el 26 Jul 2005 11:20:06 -0700
***************
*** 984,990 ****
(setq term
(if (setq hyphend (string-match "[-_][^-_]+$" term))
(substring term 0 hyphend)
! nil)))))
;; Update the out-of-memory error message based on user's key bindings
;; for save-some-buffers.
--- 984,996 ----
(setq term
(if (setq hyphend (string-match "[-_][^-_]+$" term))
(substring term 0 hyphend)
! nil)))
! (when term
! ;; The terminal file has been loaded, now call the terminal
! ;; specific initialization function.
! (let ((term-init-func (intern (concat "terminal-init-" term))))
! (when (fboundp term-init-func)
! (funcall term-init-func))))))
;; Update the out-of-memory error message based on user's key bindings
;; for save-some-buffers.
- Re: rxvt vs xterm keybindings, (continued)
- Re: rxvt vs xterm keybindings, Eli Zaretskii, 2005/07/23
- Re: rxvt vs xterm keybindings, Dan Nicolaescu, 2005/07/23
- Re: rxvt vs xterm keybindings, Eli Zaretskii, 2005/07/23
- Re: rxvt vs xterm keybindings, Stefan Monnier, 2005/07/23
- Re: rxvt vs xterm keybindings, Dan Nicolaescu, 2005/07/23
- Re: rxvt vs xterm keybindings, Richard M. Stallman, 2005/07/23
- Re: rxvt vs xterm keybindings, Dan Nicolaescu, 2005/07/25
- Re: rxvt vs xterm keybindings, Richard M. Stallman, 2005/07/26
- Re: rxvt vs xterm keybindings, Dan Nicolaescu, 2005/07/26
- Re: rxvt vs xterm keybindings, Eli Zaretskii, 2005/07/26
- Re: rxvt vs xterm keybindings,
Dan Nicolaescu <=
- Re: rxvt vs xterm keybindings, Eli Zaretskii, 2005/07/26
- Re: rxvt vs xterm keybindings, Richard M. Stallman, 2005/07/27
Re: rxvt vs xterm keybindings, Kenichi Handa, 2005/07/22