flyspell.el issues

[Stephen Eglen]

I've found a couple of issues with flyspell.el in emacs-devel.

1. M-x flyspell-buffer detects repeated words ("that that") but only
   if the buffer is regarded as "small".  To see this, create a text
   mode buffer with contents "that that" and then append into that
   buffer a long text file (e.g. etc/COPYING from Emacs sources).  If
   you then do M-x flyspell-buffer, the second instance of "that" is
   not highlighted.  If however, you then do

        (setq flyspell-large-region 999999)

   and then M-x flyspell-buffer, it now works correctly (albeit
   slower).

Could that be fixed so that repeated words are found in large regions?
Alternatively, the docsstring for flyspell-mark-duplications-flag
could be updated to say it works only for small regions?


2. flyspell-large-region is declared as:

(defcustom flyspell-large-region 1000
  "*The threshold that determines if a region is small.
If the region is smaller than this number of characters,
`flyspell-region' checks the words sequentially using regular
flyspell methods.  Else, if the region is large, a new Ispell process is
spawned for speed.

If `flyspell-large-region' is nil, all regions are treated as small."
  :group 'flyspell
  :version "21.1"
  :type '(choice number boolean))

The type declaration suggests that flyspell-large-region could also be
set to t.  Presumably that is an error (I get one when setting it to
t), so should the type be something like
  '(choice number (const nil))

Thanks, Stephen






In GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.0.6)
 of 2005-06-22 on notch.amtp.cam.ac.uk
Distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure '--prefix=/home/raid/bio/sje30/NOBACKUP/local' 
'--with-gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  iswitchb-mode: t
  partial-completion-mode: t
  display-time-mode: t
  outline-minor-mode: t
  mouse-wheel-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  menu-bar-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t
  next-error-follow-minor-mode:  Fol

Recent input:
C-x b f l y C-g C-h f f l y s p e l l <return> l a 
r <tab> <return> C-x o <tab> C-h v f l y s SPC l a 
r SPC r e SPC <tab> <M-backspace> <tab> <M-backspace> 
<M-backspace> r e g i o n <return> <M-backspace> l 
a r <tab> <return> C-x o C-x b <return> C-x b . t <backspace> 
e l <backspace> <backspace> <backspace> f l C-g C-x 
o <tab> <tab> <tab> <tab> <return> M-< M-x r e p o 
r t SPC e m a c s SPC b SPC <return>

Recent messages:
mouse-2, RET: find function's definition
Loading pp...done
Auto-saving...
Quit
mouse-2, RET: describe this function
mouse-2, RET: describe this symbol
mouse-2, RET: customize variable
mouse-2, RET: find variable's definition
Mark set
Loading emacsbug...done