[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Recent change to xdisp.c breaks minibuffer input
From: |
Kim F. Storm |
Subject: |
Recent change to xdisp.c breaks minibuffer input |
Date: |
Mon, 22 Aug 2005 10:21:22 +0200 (CEST) |
The following change has broken minibuffer input in various ways:
2005-08-20 Richard M. Stallman <address@hidden>
* xdisp.c (display_echo_area_1): Get display start pos from w->start.
(resize_mini_window): Set w->start, and PT, so as to display the tail
end of the buffer, if it doesn't all fit.
To observe one bad effect, try this:
1) Start emacs -q
2) M-: (setq max-mini-window-height 1) RET
3) C-x C-f
4) Drag the right border of the frame to make it ~5 chars wider
than the current minibuffer text
5) Enter "abcdefghijkl" RET
6) You now has a file named "abcdelkjihgf" (approximately).
Also ido-mode is completely broken by this change:
1) Start emacs -q
2) M-x ido-mode RET
3) M-: (setq ido-max-window-height 1) RET
4) C-x C-f
5) Now you see the last choices, not the start of the prompt where
all the "ido action" takes place.
In both cases, the problem is that the change does not give a damn
about where PT is -- whether it is visible or at ZV+1.
So the last sentence in this comment is definitely WRONG.
Set W->start to the right place to begin display. If the whole
contents fit, start at the beginning. Otherwise, start so as
to make the end of the contents appear. This is particularly
important for y-or-n-p, but seems desirable generally.
In GNU Emacs 22.0.50.25 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2005-08-21 on kfs-l.imdomain.dk
X server distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure 'CFLAGS=-g -O0''
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Recent change to xdisp.c breaks minibuffer input,
Kim F. Storm <=