emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: textmodes/ispell.el: aspell does not support utf-8


From: Magnus Henoch
Subject: Re: textmodes/ispell.el: aspell does not support utf-8
Date: Fri, 02 Sep 2005 14:12:16 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (berkeley-unix)

"Richard M. Stallman" <address@hidden> writes:

>     A better solution might be to extend ispell-check-version to check
>     aspell's version as well (right now it only checks whether ispell is
>     really aspell), and modify the default value of ispell-program-name to
>     use aspell only if it is >= 0.60.
>
> This is one of those problems that should not be solved.  The right
> thing to do here is to install a more recent aspell version.
>
> I don't want to complicate the code in ispell.el to cater to old
> aspell versions.  It would be a step for the worse.

I finally got around to writing a test for the aspell version.  This
patch gives a clear error message instead of mysterious problems.

2005-09-02  Magnus Henoch  <address@hidden>

        * textmodes/ispell.el (ispell-check-version): Signal an error is
        aspell version is less than 0.60.

*** ispell.el   31 Aug 2005 12:26:26 +0200      1.173
--- ispell.el   02 Sep 2005 14:09:07 +0200      
***************
*** 814,820 ****
          (goto-char (point-min))
          (let (case-fold-search)
            (setq ispell-really-aspell
!                 (and (search-forward "(but really Aspell " nil t) t))))
        (kill-buffer (current-buffer)))
      result))
  
--- 814,823 ----
          (goto-char (point-min))
          (let (case-fold-search)
            (setq ispell-really-aspell
!               (and (search-forward-regexp "(but really Aspell \\(.*\\))" nil 
t)
!                    (if (version< (match-string 1) "0.60")
!                        (error "aspell version 0.60 or greater is required")
!                      t)))))
        (kill-buffer (current-buffer)))
      result))
  





reply via email to

[Prev in Thread] Current Thread [Next in Thread]