Re: Scrolling in pc-selection mode with scroll-margin broken

[Kim F. Storm]

Eugene Vlasov <address@hidden> writes:

> Here simple test case.
>
> Steps to reproduce bug:
> 1. Run GUI version of emacs with attached .emacs file
> 2. Visit attached file 1.txt
> 3. Press <next> or M-x scroll-up-nomark <RET>

Does this patch give good results?

*** xdisp.c     27 Sep 2005 23:09:01 +0200      1.1056
--- xdisp.c     30 Sep 2005 14:29:05 +0200      
***************
*** 12848,12854 ****
        this_scroll_margin *= FRAME_LINE_HEIGHT (it.f);
  
        if ((w->cursor.y < this_scroll_margin
!          && CHARPOS (pos) > BEGV)
          /* rms: considering make_cursor_line_fully_visible_p here
             seems to give wrong results.  We don't want to recenter
             when the last line is partly visible, we want to allow
--- 12848,12855 ----
        this_scroll_margin *= FRAME_LINE_HEIGHT (it.f);
  
        if ((w->cursor.y < this_scroll_margin
!          && CHARPOS (pos) > BEGV
!          && IT_CHARPOS (it) < ZV)
          /* rms: considering make_cursor_line_fully_visible_p here
             seems to give wrong results.  We don't want to recenter
             when the last line is partly visible, we want to allow


-- 
Kim F. Storm <address@hidden> http://www.cua.dk