Re: "M-x locate" regression

[Luc Teirlinck]

Nick Roberts wrote:

   You appear to have just put back the lines removed from 21.3 and left those
   added for 22.0.50.

Yes.

   I think the idea of dired-fun-in-all-buffers is to update
   correctly when there is more than one dired buffer.

Yes.

   So, for example, I don't think your patch will work if one buffer
   uses find-dired and another normal dired, and you delete a file
   present in both buffers, from the normal dired buffer.

With my patch *Locate* and find{-grep}-dired buffers would only get
updated if the file were deleted in their own buffer.  This is not
ideal, but better than the present situation.

   For this reason, I think its important that find-dired can add to
   dired-buffers.

If I understood correctly, this requires reverting an old change by
Richard.  In that case, Richard should tell us whether that is OK or
not.  Also did you check that the way you want to do it works
correctly if you delete a file whose directory is not the *Find*
buffer's directory, but a subdirectory of it, that is, a file listed
as subdir/filename?

   delete-region could be used for locate, of course,

I guess one could also make dired-fun-in-all-buffers automatically
check all *Locate* buffers, so that *Locate* buffers would also be
updated, even if the file got deleted in another Dired buffer.  But
maybe that might be more complicated.

    possibly conditioned on major-mode not being dired-mode to make
   sure nothing gets deleted twice.

I do not believe that my patch deletes anything twice.
dired-fun-in-all-buffers can not delete anything that is not there any more.

Sincerely,

Luc.