Re: menu-updating-frame is nil on X

[Eli Zaretskii]

> From: Juri Linkov <address@hidden>
> Cc: address@hidden
> Date: Wed, 09 Nov 2005 11:38:34 +0200
> 
> > In xmenu.c the function set_frame_menubar binds menu-updating-frame to
> > the frame passed to it as argument.  Could you please look and see why
> > this isn't working as intended?
> 
> The non-toolkit version of Emacs doesn't call it at all, because
> `USE_X_TOOLKIT' and `USE_GTK' are not defined.

You are right, sorry I didn't see that myself.

> I don't know is it right to bind menu-updating-frame to the same frame
> in the non-toolkit version.  I am not familiar with this code at all,
> so please don't expect me to propose a correct change.

Well, you did suggest a patch to fix this, so I assumed you did know
something about it.

Does the following patch give good results?

Index: src/xmenu.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xmenu.c,v
retrieving revision 1.295
diff -u -r1.295 xmenu.c
--- src/xmenu.c 7 Aug 2005 12:33:19 -0000       1.295
+++ src/xmenu.c 9 Nov 2005 19:08:26 -0000
@@ -3498,6 +3498,7 @@
   /* Help display under X won't work because XMenuActivate contains
      a loop that doesn't give Emacs a chance to process it.  */
   menu_help_frame = f;
+  XSETFRAME (Vmenu_updating_frame, f);
   status = XMenuActivate (FRAME_X_DISPLAY (f), menu, &pane, &selidx,
                           x, y, ButtonReleaseMask, &datap,
                           menu_help_callback);