emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: log-view-diff


From: Nick Roberts
Subject: Re: log-view-diff
Date: Fri, 2 Dec 2005 13:49:05 +1300

 > What about the following docstring?  It should correctly document what
 > this function does.

Why require mark to abe active?  After all, only the end points are of interest
not the region in between so it could work like dired-diff in this respect.

Nick


 > Index: lisp/log-view.el
 > ===================================================================
 > RCS file: /cvsroot/emacs/emacs/lisp/log-view.el,v
 > retrieving revision 1.23
 > diff -c -r1.23 log-view.el
 > *** lisp/log-view.el 31 Aug 2005 13:50:48 -0000      1.23
 > --- lisp/log-view.el 2 Dec 2005 00:33:33 -0000
 > ***************
 > *** 196,204 ****
 >   
 >   (defun log-view-diff (beg end)
 >     "Get the diff for several revisions.
 > ! If the point is the same as the mark, get the diff for this revision.
 > ! Otherwise, get the diff between the revisions
 > ! were the region starts and ends."
 >     (interactive
 >      (list (if mark-active (region-beginning) (point))
 >            (if mark-active (region-end) (point))))
 > --- 196,204 ----
 >   
 >   (defun log-view-diff (beg end)
 >     "Get the diff for several revisions.
 > ! If point is the same as the mark or the mark is not active, get the
 > ! diff between the revision at point and the next revision.  Otherwise,
 > ! get the diff between the revisions were the region starts and ends."
 >     (interactive
 >      (list (if mark-active (region-beginning) (point))
 >            (if mark-active (region-end) (point))))
 > 
 > -- 
 > Juri Linkov
 > http://www.jurta.org/emacs/
 > 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]