Re: log-view-diff

[Juri Linkov]

>     "get the diff between the revision at point and the next revision"
>
> Wouldn't it be more natural to compare with the previous revision?
> That would show you the changes installed _in_ the revision
> that you're pointing at.

Actually it already compares with the previous revision.  I used the
phrase "the next revision" because the previous revision is accessed
by using the `n' key (`log-view-msg-next') which is the next to the
revision at point in the log buffer.  I realize that the correct term
is not the "next revision", but the "previous revision".  Below is
a new docstring:

Index: lisp/log-view.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/log-view.el,v
retrieving revision 1.24
diff -c -r1.24 log-view.el
*** lisp/log-view.el    2 Dec 2005 07:59:56 -0000       1.24
--- lisp/log-view.el    4 Dec 2005 21:44:45 -0000
***************
*** 195,204 ****
  ;;
  
  (defun log-view-diff (beg end)
!   "Get the diff for several revisions.
! If the point is the same as the mark or the mark is not active,
! get the diff for this revision.  Otherwise, get the diff between
! the revisions where the region starts and ends."
    (interactive
     (list (if mark-active (region-beginning) (point))
           (if mark-active (region-end) (point))))
--- 195,205 ----
  ;;
  
  (defun log-view-diff (beg end)
!   "Get the diff between two revisions.
! If the mark is not active or the mark is on the revision at point,
! get the diff between the revision at point and its previous revision.
! Otherwise, get the diff between the revisions where the region starts
! and ends."
    (interactive
     (list (if mark-active (region-beginning) (point))
           (if mark-active (region-end) (point))))

-- 
Juri Linkov
http://www.jurta.org/emacs/