Re: Scrolling completions with Eshell on terminal.

[Matt Hodges]

>>>>> Stefan Monnier writes:

 > Maybe you could use something like last-nonmenu-event instead so it
 > also works for people who use some other key.  Although I'm not
 > sure it actually solves your problem (I can never remember which
 > events are "raw" and which have been translated through
 > function-key-map and friends).

Do you mean like:

--- pcomplete.el        07 Feb 2006 07:59:09 +0000      1.23
+++ pcomplete.el        22 Mar 2006 07:43:03 +0000      
@@ -978,7 +978,7 @@
                (set-window-configuration pcomplete-last-window-config)
                (setq pcomplete-last-window-config nil)
                (throw 'done nil))
-              ((event-matches-key-specifier-p event 'tab)
+              ((event-matches-key-specifier-p event last-nonmenu-event)
                (save-selected-window
                  (select-window (get-buffer-window "*Completions*"))
                  (if (pos-visible-in-window-p (point-max))

This could be a step in the right direction, although (1) it doesn't
work when using pcomplete bound to a function key with -nw, and (2) it
doesn't work under XEmacs.  I doubt (1) would affect many people, but
(2) should be addressed.

Maybe something like:

--- pcomplete.el        07 Feb 2006 07:59:09 +0000      1.23
+++ pcomplete.el        22 Mar 2006 08:03:26 +0000      
@@ -978,7 +978,9 @@
                (set-window-configuration pcomplete-last-window-config)
                (setq pcomplete-last-window-config nil)
                (throw 'done nil))
-              ((event-matches-key-specifier-p event 'tab)
+              ((if (eshell-under-xemacs-p)
+                    (event-matches-key-specifier-p event 'tab)
+                  (event-matches-key-specifier-p event last-nonmenu-event))
                (save-selected-window
                  (select-window (get-buffer-window "*Completions*"))
                  (if (pos-visible-in-window-p (point-max))

Thanks,

Matt