read-face-name bugs

[Drew Adams]

1. read-face-name's prompt arg should be like every other prompt
   arg. It should not automatically add a colon and space. Besides,
   the doc string mentions that you shouldn't add a space (without
   saying why), but it neglects to mention that you shouldn't add a
   colon either.

2. I think the code is wrong for the case where there is a face
   property like this on the character: ((foreground-color
   "Firebrick")). The code tests whether the car is foreground-color
   or background-color, but it should test whether the caar is that.

   To test this, do M-x debug-on-entry read-face-name, and then M-x
   customize-face font-lock-comment-face. Then, put point on the
   second "sample" text (next to the foreground field), and do M-:
   (read-face-name "foo"). Step through the debugger, and you'll see
   that the ((foreground-color . "Firebrick")) case falls through the
   crack.


In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600)
 of 2006-03-20 on W2ONE
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Id:/g/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<report-emacs-bug>

Recent messages:
(C:\Emacs-22-2006-03-20\bin\emacs.exe -q --no-site-file --debug-init
C:\drews-lisp-20)
Loading encoded-kb...done
For information about the GNU Project and its goals, type C-h C-p.
Loading dired...
Loading regexp-opt...done
Loading dired...done
Loading emacsbug...done