Re: large value for tool-bar-button-margin crashes Emacs

[Kim F. Storm]

I have installed various changes to the tool-bar resizing code to
handle this and other problems related to incomplete tool-bar display.

I also considered some options for limiting the amount of space occupied
by the tool-bar:

- allow tool-bar to fill max 1/3 of frame height (just discard excess).

  -> the problem with this is how to create a separate frame holding just
     a tool-bar (in case someone wants to do that).

- remove the tool-bar if it doesn't fit

  -> this means that resizing a window may lose the tool-bar, but once the
     tool-bar is removed, it is hard to get back.  Or more internal
     book-keeping is needed

- make the auto-resize-tool-bars variable more flexible:

  - make it frame local

  - new values are:
    'evaporate    =>  remove tool-bar if it gets too big to fit
    0.00 .. 0.99  => allow tool-bar to fill that percentage of frame size


But I think it can wait until after the release!


"Miguel V. S. Frasson" <address@hidden> writes:

> Hi
>
> Setting tool-bar-button-margin to a sufficiently large value chashes
> Emacs.  There are two things going on: the horizontal and the vertical
> measures of the frame.
>
> If toolbar does not fit in the vertical area of the frame (but a
> single button fits in the horizontal space) then, the text window
> becomes 1 line high, and no tool-bar is displayed, only the white top
> border.  Maybe if the tool-bar does not fit, Emacs should display no
> toolbar, leaving space for the text window.
>
> The following situations happens when calling Emacs with the following
> lines:
>
> Doesn't crash
> emacs -Q --xrm "emacs.geometry:80x25" --eval "(setq tool-bar-button-margin 
> 365)"
>
> Crashes
> emacs -Q --xrm "emacs.geometry:80x25" --eval "(setq tool-bar-button-margin 
> 366)"
>
> Does not crash again
> emacs -Q --xrm "emacs.geometry:81x25" --eval "(setq tool-bar-button-margin 
> 366)"
>
> Does not crash
> emacs -Q --xrm "emacs.geometry:81x25" --eval "(setq tool-bar-button-margin 
> 369)"
>
> Crashes (increasing 1 in the button margin, increases the button size
> in 2 pixels)
> emacs -Q --xrm "emacs.geometry:81x25" --eval "(setq tool-bar-button-margin 
> 370)"
>
> (if one cannot reproduce with the values provided, for sure with other
> values, or use my emacs settings in X resources
> ! GNU Emacs
> emacs*font:   -misc-fixed-medium-*-*-*-15-*-*-*-*-*-*-*
> emacs.pane.menubar.font: -misc-fixed-bold-r-normal-*-13-*-*-*-*-*-*-*
> emacs.menu*.font:        -misc-fixed-bold-r-normal-*-13-*-*-*-*-*-*-*
> emacs.dialog*.font:      -misc-fixed-bold-r-normal-*-13-*-*-*-*-*-*-*)
>
> Miguel.
>
> If emacs crashed, and you have the emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>    `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /usr/local/share/emacs/22.0.50/etc/DEBUG for instructions.
>
>
> In GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
> of 2006-05-12 on miguel
> X server distributor `The X.Org Foundation', version 11.0.60802000
> Important settings:
>  value of $LC_ALL: nil
>  value of $LC_COLLATE: nil
>  value of $LC_CTYPE: nil
>  value of $LC_MESSAGES: nil
>  value of $LC_MONETARY: nil
>  value of $LC_NUMERIC: nil
>  value of $LC_TIME: nil
>  value of $LANG: en_US.UTF-8
>  locale-coding-system: utf-8
>  default-enable-multibyte-characters: t
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>  tooltip-mode: t
>  auto-compression-mode: t
>  tool-bar-mode: t
>  mouse-wheel-mode: t
>  menu-bar-mode: t
>  file-name-shadow-mode: t
>  global-font-lock-mode: t
>  font-lock-mode: t
>  blink-cursor-mode: t
>  unify-8859-on-encoding-mode: t
>  utf-translate-cjk-mode: t
>  line-number-mode: t
>
> Recent input:
> M-x r e p o r t <tab> <return>
>
> Recent messages:
> (emacs -Q)
> For information about the GNU Project and its goals, type C-h C-p.
> Loading emacsbug...
> Loading regexp-opt...done
> Loading emacsbug...done
>
> -- 
> Miguel Vinicius Santini Frasson
> address@hidden

-- 
Kim F. Storm <address@hidden> http://www.cua.dk