Re: should locate-file-completion filter out "./" and "../"?

[Richard Stallman]

    1. Is it at all useful to have "./" and "../" in this list?

They are files, so it would be wrong for them not to appear.

This patch should avoid the duplications; how much better is it?


*** files.el    08 Jul 2006 16:59:45 -0400      1.851
--- files.el    10 Jul 2006 12:45:48 -0400      
***************
*** 691,697 ****
        (when (file-directory-p dir)
          (dolist (file (file-name-all-completions
                         (file-name-nondirectory string) dir))
!           (push (if string-dir (concat string-dir file) file) names)
            (when (string-match suffix file)
              (setq file (substring file 0 (match-beginning 0)))
              (push (if string-dir (concat string-dir file) file) names)))))
--- 691,697 ----
        (when (file-directory-p dir)
          (dolist (file (file-name-all-completions
                         (file-name-nondirectory string) dir))
!           (add-to-list 'names (if string-dir (concat string-dir file) file))
            (when (string-match suffix file)
              (setq file (substring file 0 (match-beginning 0)))
              (push (if string-dir (concat string-dir file) file) names)))))