Re: Multiple runs of menu-bar-update-hook

[Richard Stallman]

Was update_menu_bar called twice from a single call to prepare_menu_bars?
If so, that means the mechanism I recently added to prevent that
is broken.

Or was prepare_menu_bars called twice?  If so, how was it called,
each time?

I did find a small bug in update_menu_bar which might explain the
problem.  This should fix the bug.  I doubt that the bug is relevant
in your scenario, but it might be.  So please try this fix.


*** xdisp.c     28 Jul 2006 22:00:38 -0400      1.1112
--- xdisp.c     09 Aug 2006 16:43:58 -0400      
***************
*** 9126,9132 ****
       happen when, for instance, an activate-menubar-hook causes a
       redisplay.  */
    if (inhibit_menubar_update)
!     return;
  
    window = FRAME_SELECTED_WINDOW (f);
    w = XWINDOW (window);
--- 9126,9132 ----
       happen when, for instance, an activate-menubar-hook causes a
       redisplay.  */
    if (inhibit_menubar_update)
!     return hooks_run;
  
    window = FRAME_SELECTED_WINDOW (f);
    w = XWINDOW (window);